3 ms·
It's the most important rule in my opinion. Master must always compile and pass tests. I'm glad sending patches or looking into bugs whenever I find them in OS
by ben_bai 6y ago
It's the most important rule in my opinion. Master must always compile and pass tests.
I'm glad sending patches or looking into bugs whenever I find them in OSS but having to jump through hoops just to get things compiled is a big no-no.
- jfkebwjsbx 6y agoIf you are not even compiling a change, then why would you submit it? The bot will catch it, yes, but you are still filling the queue of maintainers.
- ben_bai 6y agoNot what I wrote. I never send in untested patches, because I don't start writing patches if I cant easily compile it myself in the first place. Also, this was not specifically targeted at llvm but all open source software which may not even have a build-bot or published regression checks. All I'm saying is: Please keep master clean so it always compiles so people can easily pick it up and contribute.
- fluffything 6y ago> If you are not even compiling a change, then why would you submit it? For example, some people send doc fixes. Sometimes these doc fixes have "bugs" that actually make compilation fail. Like adding a line break and forgetting to mark the next line as a comment... Compiling LLVM for such changes takes quite a bit of time, so of course people don't even do it.
- jfkebwjsbx 6y agoThat does not answer the question.
- fluffything 6y agoOf course it does. Some changes, like doc changes, should not affect the program. So why would you try to compile your software to verify those instead of just, e.g., generating your documentation ?