18 ms·
I could see this introducing a performance hit... Previously a register address was a hardcoded constant. Very small,very fast. Now, looking up a register in
by londons_explore 6y ago
I could see this introducing a performance hit...
Previously a register address was a hardcoded constant. Very small,very fast.
Now, looking up a register ina map involves string matching on the name across every possible register in the map till you find a match. That is much slower, but also makes the kernel quite a lot larger, because you're effectively shipping half the device datasheet in the form of names for every flag bit.
- akx 6y agoThere's no string matching that I can see in the linked article?
- londons_explore 6y ago" .name = "dw-mipi-dsi"," Looks like a string in the structure to me. And when you have an array of such structures, you end up scanning through them checking for the name you need.
- akx 6y agoThat's the name of the regmap. Clicking through to the definition of the structure says it's optional and thus there for descriptive purposes. * * @name: Optional name of the regmap. Useful when a device has multiple * register regions.
- cesarb 6y agoLook at the usage example a couple of lines below; it's passing a pointer to that structure. There's no scanning necessary, it already knows where the structure is.
- kanox 6y agoAt runtime this is all just a couple of pointer indirections so the impact is minimal. There are also special functions for bulk transfer so regmap shouldn't be called in tight loops.