2 ms·
> /* Don't change these flag values! */ Rant: It always annoys me when I see comments like this in the source. If it is important enough to implore people no
by kwhitefoot 6y ago
> /* Don't change these flag values! */
Rant:
It always annoys me when I see comments like this in the source. If it is important enough to implore people not to change something then it is surely important enough to explain why.
When I saw comments like this during code reviews I always asked the author to add a comment that briefly explained the reason for the values being the way they are.
Of course this was rather rare because most developers don't write many comments in the first place.
- jwmhjwmh 6y agoYou're right. I have added a description. Thanks.
- analognoise 6y agoI love the HN live code review.
- kwhitefoot 6y agoMuch clearer. That's a faster reaction to a code review than I used to get when I was doing them 'in real life'!