5 ms·
Is it a bad code smell (see the old refactoring book)? Yes. Can there be rationale why no one acts on it? Yes. Is that okay? Yes. Code purity is not everything
by oaiey 6y ago
Is it a bad code smell (see the old refactoring book)? Yes. Can there be rationale why no one acts on it? Yes. Is that okay? Yes.
Code purity is not everything. It is a single metric. Maoni maintains this file for the .NET Framework, Silverlight, .NET Core and nowadays Mono. She and her group will have reasons.
And honestly, all accounts from her co-workers describe her as a wonderful person with incredible insights. They talk about her in deepest respect and friendliness. Calling her crazy is the opposite of reality.
- cheerlessbog 6y agoIt's Maoni and she is great. GP is unreasonably personalizing a formatting preference.
- oaiey 6y agoThanks. I corrected her name. What culture influenced reading can produce :)
- thu2111 6y agoIt seems that it's sadly as I suspected - she is allowed to get away with this because she's a woman. No male programmer who takes these attitudes would be treated this way. I'm sorry, stuffing 35,000 lines into a single C++ file so large GitHub refuses to render it is not a "formatting preference". It's a bad choice that is strongly recommended against by any kind of reasonable programming course, because it's the sort of thing that destroys code comprehensibility. It attracted an immediate attempt to start splitting the file up exactly because it's obvious it will stop people contributing - something that she appears to regard as a feature rather than a bug. In an open source project! And that's before we get into all the other problems visible from a quick 5 minute scan through the code.
- junke 6y agoPlease reread your comment and think about your attitude.
- dang 6y agoYou can't attack someone like that here and if you do it again we will ban you. Attacking unorthodox preferences in programming is bad enough. Chuck Moore and Arthur Whitney like to see their entire programs in one screen. Most people consider that crazy but they are two of the greatest programmers of all time. If someone else likes a single long file, that's their preference. Here's what we should do: stop calling people crazy and stop punishing differences. We need more outliers in programming. The reflex to knock people down when they deviate is a huge limiting factor in this business.
- pjmlp 6y agoI only know her from the talks she has given and the blog posts, she really looks wonderful person technically and privately, and a very good example to show to girls with technical aspirations.
- flocial 6y agoI saw her interview and she was just so awesome and confident. She grew up in China, graduated with a degree in Chemistry, learned to speak fluent English, and then somehow ended up being the sole maintainer (using the term loosely because she was actively improving it the whole time) of a mission critical piece of code for an entire ecosystem at Microsoft. Color me impressed. Definitely a top notch engineer regardless of gender full stop.