3 ms·
This a thousand times. If you hit a bug on my code and put together a PR to fix it, the reasons I would merge it are in order of importance: 1. For you, since
by franciscop 6y ago
This a thousand times. If you hit a bug on my code and put together a PR to fix it, the reasons I would merge it are in order of importance:
1. For you, since you are nice and helpful debugging it and fixing it for you and others so I want to make it easy for you to use the working code.
2. For other users that might hit the bug, for every PR bugfix there are likely N people hitting the bug.
3. For me in case I hit it in the future.
4. For correctness sake.
But not all bugs are straightforward, many have side-effects or disadvantages that I might not be comfortable merging straight away. So I have to evaluate how long it'll take me to review the PR and whether it's even worth-it (the vast majority of times PRs are worth-it, but issues are a hit and miss).