4 ms·

Hah, I just learned GitHub is using my Go package to access the GitHub GraphQL API v4 in this CLI. That’s neat. [1] https://github.com/cli/cli/blob/ad3a5903b2d

Hah, I just learned GitHub is using my Go package to access the GitHub GraphQL API v4 in this CLI. That’s neat. [1] https://github.com/cli/cli/blob/ad3a5903b2d327c1da8959708ef9b65b290da87e/go.mod#L20 https://github.com/cli/cli/blob/ad3a5903b2d327c1da8959708ef9...

rojaz 6y ago
That is a pretty cool achievement.
dmitshur 6y ago
If anyone is interested in learning more about the various trade-offs considered during its initial design, I gave a talk¹ about it in 2017, and wrote about some internal implementation details in a blog post². [1] https://dmitri.shuralyov.com/talks/2017/githubql/githubql.slide https://dmitri.shuralyov.com/talks/2017/githubql/githubql.sl... [2] https://dmitri.shuralyov.com/blog/25 https://dmitri.shuralyov.com/blog/25
benhoyt 6y ago
Nice! I'm not sure exactly why a rather minor update to the GitHub CLI is near the top of HN, but looking at your project (and then seeing the link to your presentation) made it worthwhile for me.
- amerine 6y ago
  Hah, same exact feels here.
chaps 6y ago
Out of curiosity, are they supporting you financially in any way for that?
- staticautomatic 6y ago
  That would be nice of them but why would they if it's MIT licensed?
  - lowdose 6y ago
    Golden rule?
    - xapata 6y ago
      GitHub is mostly free now.
  - chaps 6y ago
    I just find it weird that Microsoft owns GitHub and is essentially using free code that interfaces with their own (core) services. Anywho, building the package wasn't as altruistically motivated as I first imagined, since he was paid by Google to build it. Edit: why the downvotes?
    - dmitshur 6y ago
      (I didn’t downvote this comment.) I agree it’s interesting, but I’m glad they’re using it. It’s better than them not using it. From looking at the history, I saw they rolled their own GraphQL client first, and started using my package only a month ago. See https://github.com/cli/cli/pull/719 https://github.com/cli/cli/pull/719 and https://github.com/cli/cli/pull/758 https://github.com/cli/cli/pull/758. Also, to clarify, I did most of the development of the package in 2017 on my own accord, and joined Google in 2018. They didn’t pay me to work on it.
    - jquast 6y ago
      It's worse than that with Amazon. The AWS Elastic Beanstalk CLI imports my package, but, when prompted to interview with AWS, they absolutely insisted that I perform their clowny online technical screening. They trust to use my code in their product, but they don't trust that I know basic programming skills. The real kick in the shins is that I successfully passed this screening years ago, which they don't seem to want to count. Anyway, there are a thousand other candidates, f'em.

rojaz 6y ago

That is a pretty cool achievement.

dmitshur 6y ago

If anyone is interested in learning more about the various trade-offs considered during its initial design, I gave a talk¹ about it in 2017, and wrote about some internal implementation details in a blog post². [1] https://dmitri.shuralyov.com/talks/2017/githubql/githubql.slide https://dmitri.shuralyov.com/talks/2017/githubql/githubql.sl... [2] https://dmitri.shuralyov.com/blog/25 https://dmitri.shuralyov.com/blog/25

benhoyt 6y ago

Nice! I'm not sure exactly why a rather minor update to the GitHub CLI is near the top of HN, but looking at your project (and then seeing the link to your presentation) made it worthwhile for me.

amerine 6y ago
Hah, same exact feels here.

chaps 6y ago

Out of curiosity, are they supporting you financially in any way for that?

staticautomatic 6y ago
That would be nice of them but why would they if it's MIT licensed?
- lowdose 6y ago
  Golden rule?
  - xapata 6y ago
    GitHub is mostly free now.
- chaps 6y ago
  I just find it weird that Microsoft owns GitHub and is essentially using free code that interfaces with their own (core) services. Anywho, building the package wasn't as altruistically motivated as I first imagined, since he was paid by Google to build it. Edit: why the downvotes?
  - dmitshur 6y ago
    (I didn’t downvote this comment.) I agree it’s interesting, but I’m glad they’re using it. It’s better than them not using it. From looking at the history, I saw they rolled their own GraphQL client first, and started using my package only a month ago. See https://github.com/cli/cli/pull/719 https://github.com/cli/cli/pull/719 and https://github.com/cli/cli/pull/758 https://github.com/cli/cli/pull/758. Also, to clarify, I did most of the development of the package in 2017 on my own accord, and joined Google in 2018. They didn’t pay me to work on it.
  - jquast 6y ago
    It's worse than that with Amazon. The AWS Elastic Beanstalk CLI imports my package, but, when prompted to interview with AWS, they absolutely insisted that I perform their clowny online technical screening. They trust to use my code in their product, but they don't trust that I know basic programming skills. The real kick in the shins is that I successfully passed this screening years ago, which they don't seem to want to count. Anyway, there are a thousand other candidates, f'em.