3 ms·
Yes, first find the serious issues and then take it down with vengeance. So far only serious issue is this: https://github.com/mrc-ide/covid-sim/issues/168 htt
by yread 7y ago
Yes, first find the serious issues and then take it down with vengeance. So far only serious issue is this:
https://github.com/mrc-ide/covid-sim/issues/168 https://github.com/mrc-ide/covid-sim/issues/168
Looks linked to the awful style, though. When you have 700 LOC functions starting with
int i, j, k, l, m, i1, i2, j2, l2, m2, tn;
it does tend to happen that you reuse a variable that you shouldn't have reused
- lasagnaphil 7y agoThese variable names are all what you typically see in mathematics-heavy numerical computation code. Sometimes it’s better to let the index symbols be just symbols rather than assigning long names; otherwise it’s going to be even more difficult to read and understand.
- Gibbon1 7y ago> int i, j, k, l, m, i1, i2, j2, l2, m2, tn; Just smells like FORTRAN to me.