5 ms·

Actual code: https://github.com/mrc-ide/covid-sim https://github.com/mrc-ide/covid-sim

• dwaltrip 6y ago
  Thanks for the link. As I randomly clicked through, I wasn't that horrified until I got to this file: https://github.com/mrc-ide/covid-sim/blob/master/src/SetupModel.cpp https://github.com/mrc-ide/covid-sim/blob/master/src/SetupMo... Of course, it's absolutely insane to suggest that all of academic epidemiology should be defunded.
  • smsm42 6y ago
    > I got to this file I have no idea how ever anyone could make sure such code is correct. What I suspect happened is it was tweaked until it generated the results that seemed plausible, and then left at that. But if somewhere in that huge haystack there's some > that should be <, only by sheer luck somebody could find it. And since there's no unit tests (I was pleasantly surprised to see "test" directory but of course no unit tests there) it's probably impossible to find small errors if they still produce plausible results. > Of course, it's absolutely insane to suggest that all of academic epidemiology should be defunded. True, article probably would be much better if it stayed within the area of expertise of the writer.
    • lbeltrame 6y ago
      I'm hoping that the result of this critique, whether the model is correct or not (which is beyond the scope of the critique), will push for better software writing in academia. There's some discussion in the GH issues, too: https://github.com/mrc-ide/covid-sim/issues/165 https://github.com/mrc-ide/covid-sim/issues/165 I'm hoping it doesn't get hijacked and turns into a flamefest, which would distract from the main point.