3 ms·
Nice catch, thanks for pointing this out. I've updated the cache initialization to use `len(targetChars)` rather than `len(target)`: cache := make([]int, l
by chrfrasco 6y ago
Nice catch, thanks for pointing this out. I've updated the cache initialization to use `len(targetChars)` rather than `len(target)`:
cache := make([]int, len(targetChars)+1)
for i := 0; i < len(targetChars)+1; i++ {
cache[i] = i
}
AFAIK this makes them equivalent (fingers crossed). It seems to not have made much of a difference (-0.03s)
- Thaxll 6y agohttps://blog.golang.org/strings https://blog.golang.org/strings
- molf 6y agoThey might be equivalent (perhaps apart from other issues pointed out in other comments), but both implementations are still either 1) incorrect if UTF-8-strings are supposed to be valid input, or 2) very inefficient if only ASCII-strings are supposed to be valid input.