4 ms·

I agree with the vast majority of this, but I have a bad reaction to “praise” and the idea that you should try to have one per review. I hate praise that feels

by jchw 7y ago

I agree with the vast majority of this, but I have a bad reaction to “praise” and the idea that you should try to have one per review. I hate praise that feels forced, and it seems like this kind of practice would make it seem quite forced. I feel you could just say something like “good idea” and it would be fine without the prefix. Especially if your review tool of choice has a concept of actionable vs non-actionable comments, like Gerrit and resolved/unresolved comments.

nine_k 7y ago
Indeed! The praise should be genuine (the author finally fixes a bothersome issue, comes up with a particularly nice solution, etc), and compact. Often a :thumb-up: is totally sufficient.
souldzin 7y ago
> I hate praise that feels forced, and it seems like this kind of practice would make it seem quite forced. This is a really good point. Yeah, the `praise` comment is a call to find something to sincerely praise. If you can't find anything to praise (which is probably a warning sign that your head isn't in a happy place) don't leave a `praise`. I updated the description with a little warning about this. What do you think? https://gitlab.com/conventionalcomments/conventionalcomments.gitlab.io/-/merge_requests/12 https://gitlab.com/conventionalcomments/conventionalcomments...
battery_cowboy 7y ago
Someone's it's good just to butter someone up with an obvious but true bit of praise. It makes them feel better about themselves and they also like you more as a person because you said something nice. For example, if I told my coworker in a meeting that I was impressed by how smooth her deployment went that morning, even though we both know it wasn't hard to get it right because there wasn't much new, it still makes her feel better about her role at the company and how professional she is, clearly motivational, and maybe later she is more inclined to help me out when I've hit a wall on my project, which makes us both more efficient. It also helps her to know I'm not a jerk, so later if I give her criticism she knows I'm trying to help her because I'm not always just the guy who criticizes, I also say positive remarks. Clearly it has to be genuine praise, but I'm sure everyone can find one thing to praise in any PR.

by jchw 7y ago

nine_k 7y ago

Indeed! The praise should be genuine (the author finally fixes a bothersome issue, comes up with a particularly nice solution, etc), and compact. Often a :thumb-up: is totally sufficient.

souldzin 7y ago

> I hate praise that feels forced, and it seems like this kind of practice would make it seem quite forced. This is a really good point. Yeah, the `praise` comment is a call to find something to sincerely praise. If you can't find anything to praise (which is probably a warning sign that your head isn't in a happy place) don't leave a `praise`. I updated the description with a little warning about this. What do you think? https://gitlab.com/conventionalcomments/conventionalcomments.gitlab.io/-/merge_requests/12 https://gitlab.com/conventionalcomments/conventionalcomments...

battery_cowboy 7y ago

Someone's it's good just to butter someone up with an obvious but true bit of praise. It makes them feel better about themselves and they also like you more as a person because you said something nice. For example, if I told my coworker in a meeting that I was impressed by how smooth her deployment went that morning, even though we both know it wasn't hard to get it right because there wasn't much new, it still makes her feel better about her role at the company and how professional she is, clearly motivational, and maybe later she is more inclined to help me out when I've hit a wall on my project, which makes us both more efficient. It also helps her to know I'm not a jerk, so later if I give her criticism she knows I'm trying to help her because I'm not always just the guy who criticizes, I also say positive remarks. Clearly it has to be genuine praise, but I'm sure everyone can find one thing to praise in any PR.