3 ms·
This sounds great! I have often felt the lack of a common language to specify for each review comment if an action is expected. This looks like this convention
by Phlogistique 6y ago
This sounds great! I have often felt the lack of a common language to specify for each review comment if an action is expected. This looks like this convention solves the problem with a nice Schelling point.
nitpick (non-blocking): I won't use the "praise:" keyword as it feels robotic. Praise should feel spontaneous and authentic. But I love the general advice of trying to have at least one praise comment per code review.