5 ms·
Could/Should these be added to the Graal project as compiler optimizations?
by exabrial 7y ago
Could/Should these be added to the Graal project as compiler optimizations?
- sipkab 7y agoDefinitely not by default. This optimization messes with the stack trace, so if you throw an exception in one of the recursively called methods, it will only show up only once in the stack trace. This may very well cause confusion in cases where the developer is not aware that such optimizations have been performed. However, you can still perform the optimization on your Java bytecode classes, and then pass them to Graal. (If I understand Graal correctly.)
- igravious 7y agoCode gets optimized out of existence all the time and isn't a problem for exception handling code and debugging tools, I don't see why this would be any different. http://cesquivias.github.io/blog/2015/01/15/writing-a-language-in-truffle-part-4-adding-features-the-truffle-way/#a-lisp-birthright-tail-call-optimization http://cesquivias.github.io/blog/2015/01/15/writing-a-langua...
- sipkab 7y agoThis optimization is simply a goto to the start of the function, and reassignment of the arguments. It doesn't prevent exception handling in any way. It doesn't interfere with debugging tools. The point is that when your program throws an exception, and prints the stacktrace, you will only see a single stack frame for your method. Even if it recursively descended into itself multiple times. This is counter-intuitive as you don't see the evidence of the recursive calls in the stack trace. If you're unaware that tail recursion optimization was performed, you won't know why it seems like your method was only called once. The program flow stays the same, only the diagnostic information of the program changes.
- lalaithion 7y agoSure, but it wouldn't be that hard to do something like <677 tail calls elided> from the stack trace.
- jmaa 7y agoWell, yes, it would be that hard. The whole idea with tail call elimination is that a stack trace shouldn't be able to see the frames for the tail calls, because the tail call reuses the frame. To add support for tracking the tail call stack frames, you would need to modify the compiler to output code that specifically keeps track of "elided tail call frames", and you would need to update the stack trace traversal code to be able to recognize the extra debug information. Sure, it's something you could build into a new toolchain, but adding something like this to the JVM would be harder due to the constraints already placed on the JVM. Furthermore I don't know of such support in any toolchains, not even for Lua or Scheme, both of which guarantee tail call optimization. (If anybody has an example, please share!)
- saagarjha 7y agoJavaScriptCore keeps track of frames, even for JavaScript proper tail calls: https://webkit.org/blog/6240/ecmascript-6-proper-tail-calls-in-webkit/ https://webkit.org/blog/6240/ecmascript-6-proper-tail-calls-...
- chrisseaton 7y agoThe essential words in that article are... > There are some non-standard ECMAScript features in JavaScript that work differently in the presence of PTC. Java has a strict spec, and the relevant methods which would break aren’t non-standard like they are in JavaScript. If you’re willing to change the spec (I think Loom does) then yeah, but you can’t implement it as an ‘optimisation’ until then, because it’s not an optimisation if it changes behaviour.
- saagarjha 7y ago
- chrisseaton 7y agoThe point of the tail call is to not have to maintain the activation that you are tail calling from. So we’d need to reconstruct some information about the activation. How are you proposing we do that? From what information? Are you suggesting we could store some metadata perhaps? Can you suggest a mechanism for the metadata we should use? There’s a tricky constraint before you suggest an idea! It has to use constant storage, because making storage not grow with the number of calls is the whole point in the first place.
- ridiculous_fish 7y agoJavaScriptCore has probably the best answer for this question, and it's the hilariously-named "Shadow Chicken" mechanism. JSC's call stack is the C stack, and this stack has real TCO. There is a separate, heap-allocated "shadow" stack which records calls (but not returns). A single recycled C-stack frame may correspond to multiple shadow-stack calls, but between the two, a debugger can recover many tail calls. It's best effort. The GC may collect frames if it chooses to. Highly optimized code won't touch the shadow stack. etc. But it's good enough for a debugger. It's named "Shadow Chicken" because it's a shadow stack inspired by CHICKEN scheme, which uses the legendary Cheney-on-the-MTA strategy. https://trac.webkit.org/changeset/199076/webkit https://trac.webkit.org/changeset/199076/webkit
- deleted 7y ago[deleted]
- whateveracct 7y agoHaskell has stack traces despite pervasive TCE.
- noelwelsh 7y agoProject Loom is added TCE to the JVM. It is apparently very close to release. https://openjdk.java.net/projects/loom/ https://openjdk.java.net/projects/loom/