One issue is that you need a source of water. Another is that electrolysis is only around 70% efficient, whereas (say) lithium ion battery charging is more like

One issue is that you need a source of water. Another is that electrolysis is only around 70% efficient, whereas (say) lithium ion battery charging is more like 95% efficient.