3 ms·

> On a recent PR, someone said "you should really find a way to do x". I had already spent half a day attempting to do so. This made me feel bad because it impl

> On a recent PR, someone said "you should really find a way to do x". I had already spent half a day attempting to do so. This made me feel bad because it implied an assumption of thoughtlessness on my part and did little to help me out. But I wanted to be open to the feedback, so I spent more time trying to make it work. Finally, I brought this to the team and the consensus was that my approach was fine, that I hadn't been wrong in concluding there wasn't a good way to do x anyways. Why didn't you push back? Software is a team sport. It's a collaborative effort where people bring their own ideas and approaches to the table. When your co-worker gave you feedback in a code review, it's feedback. It's open for discussion. You could have brought it to the team earlier for more discussion or help making a decision. Nothing you described has anything to do with the tech industry.

Zelphyr 7y ago
I disagree somewhat with it being a team sport. It’s more of an art, which is the problem here. The way I solve a problem and the way you solve it may be two completely different yet perfectly valid ways. Who is right in that situation? We could go rounds arguing whose solution is better. In the end, the problem been solved. Sometimes that’s enough. We as an industry need to get better at recognizing when a problem has been sufficiently solved and move on.
- askafriend 7y ago
  > The way I solve a problem and the way you solve it may be two completely different yet perfectly valid ways. Who is right in that situation? We could go rounds arguing whose solution is better. If this is what the discussion devolves into, then I expect additional context to serve as the guiding light. What are the goals of the project? What is the timeline? What is the ROI? Who are our customers? What are their tolerances? Do we have SLAs? What internal commitments do we have to other teams? etc. If none of those are enough to serve as the guiding principle, then who really cares how a problem is solved as long as it's solved? You're building a business, not making art to be admired.

Zelphyr 7y ago

I disagree somewhat with it being a team sport. It’s more of an art, which is the problem here. The way I solve a problem and the way you solve it may be two completely different yet perfectly valid ways. Who is right in that situation? We could go rounds arguing whose solution is better. In the end, the problem been solved. Sometimes that’s enough. We as an industry need to get better at recognizing when a problem has been sufficiently solved and move on.

askafriend 7y ago
> The way I solve a problem and the way you solve it may be two completely different yet perfectly valid ways. Who is right in that situation? We could go rounds arguing whose solution is better. If this is what the discussion devolves into, then I expect additional context to serve as the guiding light. What are the goals of the project? What is the timeline? What is the ROI? Who are our customers? What are their tolerances? Do we have SLAs? What internal commitments do we have to other teams? etc. If none of those are enough to serve as the guiding principle, then who really cares how a problem is solved as long as it's solved? You're building a business, not making art to be admired.