3 ms·
The painful part is "verify output is correct" which only the person who initially did the test, can actually say it's correct or not. If a new person joins th
by diggan 7y ago
The painful part is "verify output is correct" which only the person who initially did the test, can actually say it's correct or not.
If a new person joins the codebase and sees that a snapshot is now different, how they know what's correct or not? What I've seen in the wild is 1) talk with the person who authored the test or 2) just say yes and move on.
- Tyr42 7y agoI mean you should have the context of your change right. If you're submitting a change to reduce the margins on everything, you should expect to need a new snapshot. If you're are doing a pure refactor of your css, you shouldn't see a change. Unless your css rules are order dependent and now you caught that.
- pydry 7y agoMaking it the snapshot behavior based and comprehensible to the product owner helps with that.