3 ms·
Constructive recommendations: - add tests (I couldn't find a simple _test.go file) - relative imports aren't recommended in Go (pkgs like "sorcia/model") - p
by yandrypozo 7y ago
Constructive recommendations:
- add tests (I couldn't find a simple _test.go file)
- relative imports aren't recommended in Go (pkgs like "sorcia/model")
- please rethink/avoid global (package) variables like middlewareDB (https://git.mysticmode.org/r/sorcia/tree/master/middleware/middleware.go#L14 https://git.mysticmode.org/r/sorcia/tree/master/middleware/m...)
- avoid adding logic in the init() functions
- screenshots?
- platinumrad 7y agoAll of those seem fine aside from logic in init() functions. In particular, not sure how global variables in someone else's code impacts you.