3 ms·
Perhaps the author doesn't realize that WebKit is open source. They could have used their screed to propose to the WebKit team that a first-party page loaded fr
by floatingatoll 7y ago
Perhaps the author doesn't realize that WebKit is open source. They could have used their screed to propose to the WebKit team that a first-party page loaded from a file:/// URI not have its client-side storage subject to the 7-day purge, by setting the "firstPartyWebsiteDataRemovalMode" network connection property to "none" — patch included! But they did not, which is quite disappointing.
The new change to ITP is here: https://github.com/WebKit/webkit/commit/4db42c1571d821572ea91abe10aedf942b774562 https://github.com/WebKit/webkit/commit/4db42c1571d821572ea9...
The cookie filtering logic specifically is located here: https://github.com/WebKit/webkit/search?q=filtercookies https://github.com/WebKit/webkit/search?q=filtercookies
The file:/// handler is implemented here: https://github.com/WebKit/webkit/blob/master/Source/WebCore/fileapi/File.cpp https://github.com/WebKit/webkit/blob/master/Source/WebCore/...
(I don't have anything to do with Apple or WebKit.)
- DiabloD3 7y agoApple does not use that Webkit branch, however. They maintain their own branch internally that cherry picks from upstream. Webkit could very well accept a patch, and then Safari never ships that patch because they disagreed with it for use in Safari. Also, unrelated fun fact: Did you know Webkit still uses svn? That Github repo you linked to is a clone of Webkit's own git repo (git.webkit.org), which is a mirror of their actual repo (svn.webkit.org).