3 ms·

I wanted to also introduce PR title validation, so there is no mistake possible on merging and we follow convetional commits 100% but unfortunately GitHub Actio

I wanted to also introduce PR title validation, so there is no mistake possible on merging and we follow convetional commits 100% but unfortunately GitHub Actions do not support fork-based workflow properly and those PR checks would be useless :(

time0ut 7y ago
Oh, that is unfortunate. Hopefully they fix that. For now, it might be worth writing a little bot that will flag PRs with noncompliant commit messages and titles.
jakear 7y ago
> GitHub Actions do not support fork-based workflow properly Could you elaborate on this?
- derberg 7y ago
  Take a look on my blog post about it https://dev.to/derberg/github-actions-when-fascination-turns-into-disappointment-4d75 https://dev.to/derberg/github-actions-when-fascination-turns.... I already reported this to GitHub Actions team and seems they are working on that. For reference https://github.community/t5/GitHub-Actions/GitHub-Action-workflow-is-executed-for-a-PR-from-a-forked-repo/m-p/50654#M7914 https://github.community/t5/GitHub-Actions/GitHub-Action-wor...
  - jakear 7y ago
    Ah yes, fork. My mind read that as branch as we barely ever use forks (enterprise environment and all) Issue comment-triggered Actions have a write-access GITHUB_TOKEN, unless I’m mistaken. You could implement the /ok-to-test flow with that. (I’m working on converting some of VSCode’s triage automation to Actions, for reference)
    - derberg 7y ago
      Guy from GitHub suggested the same, but how would you really see such workflow in action? all I have in mind seems so complicated that easier would be to write and host dedicated bot really. Supporting PR on Issue level sounds strange