33 ms·

> Google places very little emphasis on things like code readability and testability. Why do you say this? I've seen the opposite. I can't submit untested cod

> Google places very little emphasis on things like code readability and testability. Why do you say this? I've seen the opposite. I can't submit untested code or code that doesn't have "readability" approval. It's certainly not perfect but testability is a huge part of any project I've worked on.

twitch-chat 7y ago
Not to mention a lot of the open source stuff at Google like Chromium or Android is very readable.
kortilla 7y ago
The “readability” label comes from other “brilliant” Google engineers. Also, tested code is not the same thing as “testable” code. Mock and monkey patching can very easily give you 100% coverage of untestable code with garbage tests.
- joshuamorton 7y ago
  > The “readability” label comes from other “brilliant” Google engineers. This doesn't mean it leads to complex code. The Google cpp style guide[0], for example, tries at length to keep code simple and stresses that even in C++, you should prefer simple things unless the performance benefits (of, say, nontrivial ownership) are provably necessary: > The performance costs of value semantics are often overestimated, so the performance benefits of ownership transfer might not justify the readability and complexity costs. [0]: https://google.github.io/styleguide/cppguide.html https://google.github.io/styleguide/cppguide.html
  - kortilla 7y ago
    > > The “readability” label comes from other “brilliant” Google engineers. > This doesn't mean it leads to complex code. It does mean that it’s a completely subjective thing coming from other people in the very same culture of which I’m being critical. It’s like someone claiming the Chinese government isn’t authoritarian because Chinese citizens have slapped on the “non-authoritarian” label.

33 ms·

> Google places very little emphasis on things like code readability and testability. Why do you say this? I've seen the opposite. I can't submit untested cod

by thelean12 7y ago

twitch-chat 7y ago
Not to mention a lot of the open source stuff at Google like Chromium or Android is very readable.
kortilla 7y ago
The “readability” label comes from other “brilliant” Google engineers. Also, tested code is not the same thing as “testable” code. Mock and monkey patching can very easily give you 100% coverage of untestable code with garbage tests.
- joshuamorton 7y ago
  > The “readability” label comes from other “brilliant” Google engineers. This doesn't mean it leads to complex code. The Google cpp style guide[0], for example, tries at length to keep code simple and stresses that even in C++, you should prefer simple things unless the performance benefits (of, say, nontrivial ownership) are provably necessary: > The performance costs of value semantics are often overestimated, so the performance benefits of ownership transfer might not justify the readability and complexity costs. [0]: https://google.github.io/styleguide/cppguide.html https://google.github.io/styleguide/cppguide.html
  - kortilla 7y ago
    > > The “readability” label comes from other “brilliant” Google engineers. > This doesn't mean it leads to complex code. It does mean that it’s a completely subjective thing coming from other people in the very same culture of which I’m being critical. It’s like someone claiming the Chinese government isn’t authoritarian because Chinese citizens have slapped on the “non-authoritarian” label.