6 ms·
If you’re interested in becoming a software engineer or are junior, do not read this and cargo cult it because many of these things will not be good practices f
by kortilla 7y ago
If you’re interested in becoming a software engineer or are junior, do not read this and cargo cult it because many of these things will not be good practices for 99.99% of the industry.
Google has custom tooling, custom kernels, custom hardware, etc and legions of support at every layer of the stack. Complexity is not eschewed but it is rather embraced if it means some slight improvement in utilization or better looking latency distribution.
Those goals are not sustainable in normal businesses, even tech ones.
Google places very little emphasis on things like code readability and testability because it’s easy for them to do rewrites or just run tests on 1 million cores to shake out race conditions and locks.
Read this for entertainment but don’t try to blindly apply it to your work environment. Most of it will make you a bad engineer for non-FAANG envs.
- getmeoutofhere 7y agoAre you saying this as an ex-Googler / current Googler? Otherwise, please give some citations for some of your claims.
- syndacks 7y agoTheir Google status is irrelevant. The nature of their comment is that there's a propensity to emulate big tech when it's not needed. Off the top of my head: Kubernetes, microservices. My citation is news.ycombinator.com.
- teen 7y agoas someone who worked previously at google, and went back to the start up world working with php mysql, this is not true at all
- Lammy 7y agoHow is it not? Seems like simple economics to me. Something like maintaining a custom kernel distribution takes ${x} amount of engineer time for ${y} amount of “savings” (better perf, custom patches, nonstandard features, whatever). Why bother until you have a fleet of machines large enough for y to be greater than x?
- thelean12 7y agoI don't have numbers but I feel this is exaggerated. Most people work on pretty normal stuff. The biggest proprietary sink for most people is stuff like the build system/tooling/etc. Not many people have to be in a role where you're micro-optimizing something. They certainly exist, but not in the numbers some people on here seem to think.
- thelean12 7y ago> Google places very little emphasis on things like code readability and testability. Why do you say this? I've seen the opposite. I can't submit untested code or code that doesn't have "readability" approval. It's certainly not perfect but testability is a huge part of any project I've worked on.
- twitch-chat 7y agoNot to mention a lot of the open source stuff at Google like Chromium or Android is very readable.
- kortilla 7y agoThe “readability” label comes from other “brilliant” Google engineers. Also, tested code is not the same thing as “testable” code. Mock and monkey patching can very easily give you 100% coverage of untestable code with garbage tests.
- joshuamorton 7y ago> The “readability” label comes from other “brilliant” Google engineers. This doesn't mean it leads to complex code. The Google cpp style guide[0], for example, tries at length to keep code simple and stresses that even in C++, you should prefer simple things unless the performance benefits (of, say, nontrivial ownership) are provably necessary: > The performance costs of value semantics are often overestimated, so the performance benefits of ownership transfer might not justify the readability and complexity costs. [0]: https://google.github.io/styleguide/cppguide.html https://google.github.io/styleguide/cppguide.html
- kortilla 7y ago> > The “readability” label comes from other “brilliant” Google engineers. > This doesn't mean it leads to complex code. It does mean that it’s a completely subjective thing coming from other people in the very same culture of which I’m being critical. It’s like someone claiming the Chinese government isn’t authoritarian because Chinese citizens have slapped on the “non-authoritarian” label.
- alarge 7y agoChiming in here to agree with the others. In particular, finding simple, understandable solutions to complex problems is highly valued at Google. Complex solutions are an anti-pattern. And the comment about readability and testability is so far different from my experience that I have to wonder where the poster is getting their information. Google code reviews have to be among the most nit-picky I've ever seen in a 30+ year career, with serious attention to detail all the way down to punctuation in comments.
- kortilla 7y agoNit-picky reviews are a smell, not a good thing. It can often mean that the reviewer is not really reviewing the big picture (is the intent of the change being fulfilled, is this the right place in the architecture, etc) and it making up for it by focusing on irrelevant details. Seriously, code review on punctuation in a comment is not good in any scenario and it speaks nothing to the legibility of the code itself. If anything, it might mean the code is unreadable and the reviewer is too embarrassed to point out that they can’t follow it.
- joshuamorton 7y agoThis conclusion doesn't, at all, follow from the premise. While yes, nit-picky review could mean the reviewer doesn't understand the big picture, an LGTM with no comments at all is more likely to be indicative of missing something. What you really mean is that nit-picky reviews that don't pick up on actual logic or functionality issues are a smell. Which is true, but isn't usually the case at Google[0]. The chapter on teamwork covers some relevant concepts (like psychological safety). [0]: https://testing.googleblog.com/2018/05/code-health-understanding-code-in-review.html https://testing.googleblog.com/2018/05/code-health-understan...
- kortilla 7y agoThe comment I replied to is literally highlighting people nit-picking punctuation as if it’s a good thing.
- deleted 7y ago[deleted]
- kinkrtyavimoodh 7y ago> Google places very little emphasis on things like code readability and testability because it’s easy for them to do rewrites or just run tests on 1 million cores to shake out race conditions and locks. This is complete nonsense. Google's code review and testing and reliability practices are better and more sensible than most big and small companies I have worked for and heard about.
- kortilla 7y agoI didn’t say anything about reliability now did I?
- kwhat4 7y agoI think you have a point here, but it was not well articulated in your post. Much of the industry doesn't focus on software engineering only programming which leads to massive unmaintainable garbage codebases. These are the same people that want to save a few dollars by outsourcing the work to low cost places like India and are too ignorant to realize that the development takes 10x as long for a product that is unusable. My best advice would be to avoid these organizations as they will never value the engineering and only seem to focus on the lines of code output as a metric of productivity. Unfortunately this is a lot of the "industry," however I believe the 99.9% is a bit of an exaggeration. As software engineers, we should find value this sort of information regardless of our current employers opinion and hope that we can land at an institution that values engineering.
- tituswinters 7y agoThe opening chapter is very clear on that point: this is a scouting report of a software ecosystem that works at scale, what things we think are a good idea generally. It is not a "This is how you should do it," in that Google's requirements are a few orders of magnitude different than others (expected code lifetime, codebase size, engineering population, compute requirements).