3 ms·
This. I've had to spend time fixing history after a Jr engineer did a bad rebase. After a few episodes of that I decided I had to either stop hiring Jr engineer
by jmvoodoo 7y ago
This. I've had to spend time fixing history after a Jr engineer did a bad rebase. After a few episodes of that I decided I had to either stop hiring Jr engineers, have them always supervised by a Sr engineer, or stop rebasing.
I stopped rebasing.
- u801e 7y ago> I've had to spend time fixing history after a Jr engineer did a bad rebase. I tell people to run git log -p --reverse origin/master.. on the rebased branch and check that everything works before they push up their branch to the remote. I also tell them to run git rebase --exec "linting-command" --exec "unit-test-command" --exec "integration-test-command" and make sure that tests pass for every single commit. If they don't, then they spend time fixing it until they do.
- Buttons840 7y agoYou'd be better off blaming the force push rather than the rebase. A rebase I do on my computer will not affect you unless I force push. I think it's completely reasonable to ask all developers to get a second opinion before force pushing.