3 ms·
In my experience this usually boils down to different opinions on design decisions or the best way to implement a feature. One way to mitigate is to hold a des
by sjg007 7y ago
In my experience this usually boils down to different opinions on design decisions or the best way to implement a feature. One way to mitigate is to hold a design review where you get their sign off before the PR. Outline the basic strategy and pseudo-code. Document the functional interfaces etc...
The other thing to do is to ask for specific feedback to get to the root cause of the disagreement. I try to disarm them by agreeing that the code "smells" but it was the best you could do given the constraints. Does this developer "own" the code (is it their baby) or product you are working on? Ask what they would do... you can't mind read after all.
If you've built group consensus first then the negative reviewer has less room to maneuver as well.
Next consider proposing that the group create a code review protocol. This is similar to a coding style convention. Try to get consensus and sign off.
Lastly, check out the 5 secrets to effective communication, they really work. It's takes a lot of practice though.
https://feelinggood.com/2016/12/12/014-the-five-secrets-of-effective-communication-part-1/ https://feelinggood.com/2016/12/12/014-the-five-secrets-of-e...