4 ms·

Every RuboCop rule is reasonable. That is, you can look up the reason and see if you agree or not. Our team has overridden about a dozen rules (we bumped up li

Every RuboCop rule is reasonable. That is, you can look up the reason and see if you agree or not. Our team has overridden about a dozen rules (we bumped up line length and class length), but I find most of the default rules are fine. Out of curiosity, what rules are unreasonable to you?

nimblegorilla 7y ago
In my opinion the rules about requiring or forbidding parentheses are fairly arbitrary. Sometimes it's really nice to fit three panes of code on a single laptop screen. Long lines can also indicate a code smell. It's ironic that one of the first things most teams change is the 80 character line length.
chrisseaton 7y ago
Some rules break Ruby semantics - if you apply their 'rule' you get a program that does something different! I think that's an unreasonable rule.
hartator 7y ago
‘private’ methods forced to be NOT indented.
22c 7y ago
Not every rule has a reason, some of it is just "because style guide" and if you try to look up the rationale there, you'll find none. Classic example is Perl style %w(literal arrays) vs ['traditional', 'arrays']. > Prefer `%w` to the literal array syntax when you need an array of strings Which was introduced[1] into the style guide nearly 9 years ago with practically no reasoning. Prefer `%w` because why exactly? [1] https://github.com/rubocop-hq/ruby-style-guide/commit/b27eff1b2ca6ee7502bb0c53afec4f25ae154a19 https://github.com/rubocop-hq/ruby-style-guide/commit/b27eff...
- hirundo 7y ago
  I prefer the brackets to parens because it makes it more clear at a glance that the result is an array.
- block_dagger 7y ago
  Shorter. Different code coloring. I prefer %w where possible with or without Rubocop.
sbaha88 7y ago
I remember having a bug because Rubocop changed 'and' to '&&'. I don't think that a linter should have a rule that breaks the language rules
- joeframbach 7y ago
  Yup. `conditional or return fallbackValue`. Rubocop desperately wants to change this to `conditional || return fallbackValue` but that's just.... not a thing.
whalesalad 7y ago
FWIW, I was just sharing this with someone the other day when discussing the same issue https://gist.github.com/whalesalad/820810f2e969eef816402241a27a9743 https://gist.github.com/whalesalad/820810f2e969eef816402241a...
mega-tux 7y ago
Gems in Gemfile ordered alphabetically :/

nimblegorilla 7y ago

In my opinion the rules about requiring or forbidding parentheses are fairly arbitrary. Sometimes it's really nice to fit three panes of code on a single laptop screen. Long lines can also indicate a code smell. It's ironic that one of the first things most teams change is the 80 character line length.

chrisseaton 7y ago

Some rules break Ruby semantics - if you apply their 'rule' you get a program that does something different! I think that's an unreasonable rule.

hartator 7y ago

‘private’ methods forced to be NOT indented.

22c 7y ago

Not every rule has a reason, some of it is just "because style guide" and if you try to look up the rationale there, you'll find none. Classic example is Perl style %w(literal arrays) vs ['traditional', 'arrays']. > Prefer `%w` to the literal array syntax when you need an array of strings Which was introduced[1] into the style guide nearly 9 years ago with practically no reasoning. Prefer `%w` because why exactly? [1] https://github.com/rubocop-hq/ruby-style-guide/commit/b27eff1b2ca6ee7502bb0c53afec4f25ae154a19 https://github.com/rubocop-hq/ruby-style-guide/commit/b27eff...

hirundo 7y ago
I prefer the brackets to parens because it makes it more clear at a glance that the result is an array.
block_dagger 7y ago
Shorter. Different code coloring. I prefer %w where possible with or without Rubocop.

sbaha88 7y ago

I remember having a bug because Rubocop changed 'and' to '&&'. I don't think that a linter should have a rule that breaks the language rules

joeframbach 7y ago
Yup. `conditional or return fallbackValue`. Rubocop desperately wants to change this to `conditional || return fallbackValue` but that's just.... not a thing.

whalesalad 7y ago

FWIW, I was just sharing this with someone the other day when discussing the same issue https://gist.github.com/whalesalad/820810f2e969eef816402241a27a9743 https://gist.github.com/whalesalad/820810f2e969eef816402241a...

mega-tux 7y ago

Gems in Gemfile ordered alphabetically :/