4 ms·

Questions aside, I honestly thought the steps to submit a new question was satire... Contributing 1. Fork it 2. Run npm install 3. Add your resource to

Questions aside, I honestly thought the steps to submit a new question was satire... Contributing 1. Fork it 2. Run npm install 3. Add your resource to questions.json 4. Run node index to update README.md with your changes 5. Create your feature branch (git checkout -b my-new-feature) 6. Commit your changes (git commit -am "Add some feature") 7. Push to the branch (git push origin my-new-feature) 8. Create new Pull Request https://github.com/VGraupera/1on1-questions#contributing https://github.com/VGraupera/1on1-questions#contributing

deleted 7y ago
[deleted]
BossingAround 7y ago
> I honestly thought the steps to submit a new question was satire... I know, right? No Kubernetes deployment configs to check whether it builds and runs as a micro-service in the cloud? Pff!
noobermin 7y ago
I visibly grimaced when I saw this. This is straight up ridiculous.
JMTQp8lwXL 7y ago
If they ever make a website for the collected data, consuming JSON is less brittle than parsing a README file.
- daeken 7y ago
  It's Markdown, not just "a README file". It's designed to be easy to edit by hand and easy to parse; there's literally nothing at all gained by using the JSON file that they have. At all.
  - JMTQp8lwXL 7y ago
    You'd be more likely to have a bug parsing the markdown file than the structured JSON. There aren't many tools out there for converting markdown files into JSON and piecing what you want out of it.
  - deleted 7y ago
    [deleted]
- vgraupera 7y ago
  Yes, the JSON version is for use in a website or app.
- deleted 7y ago
  [deleted]
smichel17 7y ago
While making no comment on whether it is ridiculous, I'll point out that steps 1 and 5+ are the same as I'd do to send a PR anywhere, so it's really steps 2, 3, and 4 we're talking about. That is, let's just make sure we're criticising the actions required, not the number of steps involved.
- rtkwe 7y ago
  That's only really necessary because of the weird (imo) decision to manage the questions via a nodejs script instead of just having people edit the README. What's the actual benefit to creating these extra steps?
vgraupera 7y ago
Oops, I must have just cut and paste from another project. Yeah, all this is not necessary in this case. I will update it.
keehun 7y ago
This has been changed, and it's a much simpler, less ridiculous list now: https://github.com/VGraupera/1on1-questions/commit/b90e94f6bb6171f2d18f91b1f81c09bad7a8584d https://github.com/VGraupera/1on1-questions/commit/b90e94f6b...
admax88q 7y ago
> 2. Run npm install For a fucking bullet list. Our industry is broken.
- pietrovismara 7y ago
  Or maybe inform yourself before jumping on the hate train. The script is necessary to convert the json file to markdown. The source format is json so that these questions can be easily loaded in other mediums such as mobile apps. I don't really see what's the problem with it.

deleted 7y ago

[deleted]

BossingAround 7y ago

> I honestly thought the steps to submit a new question was satire... I know, right? No Kubernetes deployment configs to check whether it builds and runs as a micro-service in the cloud? Pff!

noobermin 7y ago

I visibly grimaced when I saw this. This is straight up ridiculous.

JMTQp8lwXL 7y ago

If they ever make a website for the collected data, consuming JSON is less brittle than parsing a README file.

daeken 7y ago
It's Markdown, not just "a README file". It's designed to be easy to edit by hand and easy to parse; there's literally nothing at all gained by using the JSON file that they have. At all.
- JMTQp8lwXL 7y ago
  You'd be more likely to have a bug parsing the markdown file than the structured JSON. There aren't many tools out there for converting markdown files into JSON and piecing what you want out of it.
- deleted 7y ago
  [deleted]
vgraupera 7y ago
Yes, the JSON version is for use in a website or app.
deleted 7y ago
[deleted]

smichel17 7y ago

While making no comment on whether it is ridiculous, I'll point out that steps 1 and 5+ are the same as I'd do to send a PR anywhere, so it's really steps 2, 3, and 4 we're talking about. That is, let's just make sure we're criticising the actions required, not the number of steps involved.

rtkwe 7y ago
That's only really necessary because of the weird (imo) decision to manage the questions via a nodejs script instead of just having people edit the README. What's the actual benefit to creating these extra steps?

vgraupera 7y ago

Oops, I must have just cut and paste from another project. Yeah, all this is not necessary in this case. I will update it.

keehun 7y ago

This has been changed, and it's a much simpler, less ridiculous list now: https://github.com/VGraupera/1on1-questions/commit/b90e94f6bb6171f2d18f91b1f81c09bad7a8584d https://github.com/VGraupera/1on1-questions/commit/b90e94f6b...

admax88q 7y ago

> 2. Run npm install For a fucking bullet list. Our industry is broken.

pietrovismara 7y ago
Or maybe inform yourself before jumping on the hate train. The script is necessary to convert the json file to markdown. The source format is json so that these questions can be easily loaded in other mediums such as mobile apps. I don't really see what's the problem with it.