3 ms·
I am always amazed at the quality of linux kernel commit messages.
by georgyo 7y ago
I am always amazed at the quality of linux kernel commit messages.
- wadkar 7y agoIndeed, my personal rule of thumb is if the ratio of commit message to diff is greater than one then it’s a good commit. Larger the ratio better the commit and you would do better to read the commit (as opposed to skimming through them). Chances are, you’ll learn something new.
- kees99 7y agoIndeed. Those two lines in the test-case are particularly excellent: /* 64 processes */ fork(); fork(); fork(); fork(); fork(); fork(); I can totally see most people, myself included, writing a dozen of lines instead, with a for loop, checking for parent/child/error return code, etc. Which might be preferable for some code somewhere deep inside the app logic that will potentially run on a resource-constrained machine. But for the explanation code to be read by a human, this one-liner is such a good choice!