3 ms·
I agree it might look a bit excessive, but it greatly cuts down on complexity and possible unexpected behavior. If you accept '60s' as 60 seconds, then the nex
by tijmendj 7y ago
I agree it might look a bit excessive, but it greatly cuts down on complexity and possible unexpected behavior.
If you accept '60s' as 60 seconds, then the next questions are:
- Will it also accept '60000ms'?
- What does it do if I pass an int or float anyway? Will it implicitly take it to be seconds?
- Will it throw an exception if I use an unexpected value? If so, which exceptions can I expect? Will it just chug along and use a default?
- VBprogrammer 7y agoSomething I picked up from another developer is to use timedelta for these type of parameters. It avoids hoping that you get the right granularity for everyone. retry_window_after_first_call=timedelta(minutes=3.5) retry_window_after_first_call=timedelta(days=2) retry_window_after_first_call=timedelta(minutes=50)
- leetrout 7y agoNice! Yes this is the better option. IMO, should just be retry_window=timedelta(...)