3 ms·
Seems like a good option would be to implement a second version that has the batch API but leave the line oriented one as is for use by the callers expect it to
by triztian 7y ago
Seems like a good option would be to implement a second version that has the batch API but leave the line oriented one as is for use by the callers expect it to behave in a per-line oriented way.
- magicalhippo 7y agoYeah, still won't be easy to integrate the batch optimizations now, since all the code in this module is written with the single-line-at-a-time assumption.
- spockz 7y agoIt seems to me that this would be an area where something like reactive streams excel at. The interface is by default streaming and the code dealing with the database could decide to buffer the incoming stream to an optimal amount for creating a query. (Of course only buffering until a maximum latency was reached.) This way neither the producer nor the consumer need to be aware of the exact buffer requirements and the whole can be optimised using back pressure.
- magicalhippo 7y agoWould be interesting to try, sadly not any library support in the language we use.
- Retric 7y agoThat opens things up for a host of long term maintenance issues. It might still be worthwhile, but it’s worth a serious discussion at a minimum.
- vhvjkyhkogvv 7y agoIf the single line one delegates to the batch one it should solve most of them.
- deleted 7y ago[deleted]