3 ms·
Nice list but for me missing the most difficult pieces - while giving a review, how to not focus on superficial details but instead really take the time to und
by kevsim 7y ago
Nice list but for me missing the most difficult pieces
- while giving a review, how to not focus on superficial details but instead really take the time to understand the problem and the solution. Making sure you can really understand why things were done the way they were and thinking about whether things could be made more clear, performant, follow best practices more closely, etc
- when receiving a review learning that people are reviewing it your code not you, learning how to look forward to reviews because they make your final product better
Would love to see advice on the really difficult bits of code review
- arexxbifs 7y agoThis, and especially the first point, is key to good reviews. It is also why good code reviews take time - sometimes (almost) as long as actually writing the code.