3 ms·
2 tips for code reviews: 1. It's all a give and take. Implementing changes your peers request makes them understand you value their opinion. This can make othe
by Matthias247 7y ago
2 tips for code reviews:
1. It's all a give and take. Implementing changes your peers request makes them understand you value their opinion. This can make other interactions easier - e.g. the ones where your standpoint is important to you and you don't want to derive from your opinion/code/design/etc. Save your energy for those discussions, and lean in on proposals for which your passion is lower.
2. If you do not get a common opinion after 2 review comments back of forth go to the person and talk them in person. If you or they are remote, give the a call ("Hey, do you have some time? I would like to know more about your suggestions"). Then everyone can present their standpoint again. Sometimes that already helps, because things get lost in comments. If there is still a disagreement it's still often easier (and definitely faster!) to work out.