5 ms·
> If the changes are indeed inconsequential and a matter if taste, it is a waste of his time to mention these things and a waste of your times to change them.
by rumanator 7y ago
> If the changes are indeed inconsequential and a matter if taste, it is a waste of his time to mention these things and a waste of your times to change them.
How about the time you spend debating about your refusal to accept suggestions? Is it not wasted effort as well?
And what's the impact on productivity and team velocity of fostering an unwelcoming environment where petty team members are irrationally inflexible and refuse to take suggestions even regarding innocuous changes?
- gherkinnn 7y agoConsider this “refusal” an investment. There is technical debt and there might as well be social debt. Further, I don’t see how not doing unnecessary stuff as “fostering an unwelcome environment”. It seems to me as this topic is not so much about code reviews, but about how many people are unable to confront others. All for the sake of a “welcoming environment”. In reality everybody is upset, grudges are building, one schemes in the shadows, and everybody is upset anyway. If that isn’t “unwelcoming” I don’t know what is.
- rumanator 7y ago> Further, I don’t see how not doing unnecessary stuff as “fostering an unwelcome environment”. You're the one classifying other people's work as unnecessary fluff. If your colleagues went through the trouble to provide you with patches and suggestions them they don't see it as fluff. And labelling being an uncooperative and unhelpful colleague as "social debt " doesn't fix the problems you're creating for the team.