3 ms·
If the comments are non-blocking, I usually accept the diff and leave it to the submitter to do as they please with the review comments.
by Jagat 7y ago
If the comments are non-blocking, I usually accept the diff and leave it to the submitter to do as they please with the review comments.
- justatdotin 7y agoyeah I like this workflow. If I make comments, but approve, it means I'm happy to accept it as is, but you could address these simple changes before merging if you like.