3 ms·
Skimming the code now. Looks clean and DRY, maybe a bit define-happy. Definitely better than I'd have written it.
by cousin_it 18y ago
Skimming the code now. Looks clean and DRY, maybe a bit define-happy. Definitely better than I'd have written it.
- gms 18y agoDon't be so quick to make that judgment regarding your code - they had a lot of opportunities to iterate.
- schtog 18y agoIt was writeen in LISP first so a lot of defs make sense if just porting the code. What's wrong with a lot of defs anyway?
- cousin_it 18y agoNothing wrong, it's a matter of taste. To me there are two kinds of code: "worker code" that does actual work, and "managerial code" that passes the buck. Lots of managerial code, deep call stacks, short extracted methods that are used only once etc. are heavy smells to me. Not saying this is the case with the reddit codebase!