4 ms·
I'm very unhappy with gerrit. It doesn't support git style branches, and instead uses a made up "Change-Id" scheme where you embed some magic in commit messages
by gorset 16y ago
I'm very unhappy with gerrit. It doesn't support git style branches, and instead uses a made up "Change-Id" scheme where you embed some magic in commit messages. If you want to fix issues with a commit after a review, you can reuse this "Change-Id" to update the changeset for the review.
It get worse. If you have a nice branch with several commits, they must all be reviewed separately with little help to review the branch as a whole. This feels like a throwback to the old days with CVS and patch-sets. Branching and merging suddenly becomes expensive.
If you combine this with a policy of auto-merging upon successful review, you are basically screwed if you have multiple depending commits. You must use rebase and squash to make it livable.
Sorry for the bitterness :-) I just had to review a single commit with 4000+ lines in gerrit.
- dlsspy 16y agoI reject those commits right off the top. The things you are complaining about are all things that I enjoy about gerrit. I tend to rebase on pull and use cherry-pick as the submit mechanism so it fits naturally into the flow of my groups.