3 ms·

I'm not talking about people mistaking juniors for seniors. I'm talking about when a reviewer lacks the context to understand what your code is trying to accomp

I'm not talking about people mistaking juniors for seniors. I'm talking about when a reviewer lacks the context to understand what your code is trying to accomplish - which happens all the time, even on well-functioning teams. Those situations require you speak up and at least try to clue the person in. And yes - if you automatically fire off any change requested of you, then it does give the impression that you don't know what you're doing or don't care. I'm talking from experience.

JohnFen 7y ago
> I'm talking about when a reviewer lacks the context to understand what your code is trying to accomplish - which happens all the time, even on well-functioning teams. Yes, this is why my approach is to discuss it with the reviewer. > I'm talking from experience. We have very different experiences, then. Fair enough!