2 ms·
Judge for yourself: https://web.archive.org/web/20200116203731/https://github.com/actix/actix-net/issues/83 https://web.archive.org/web/20200116203731/https://g
by jeltz 7y ago
Judge for yourself: https://web.archive.org/web/20200116203731/https://github.com/actix/actix-net/issues/83 https://web.archive.org/web/20200116203731/https://github.co...
- ryandrake 7y agoIt seems like the better solution here would have been for the folks who wanted a fixed version of the software to create and maintain a "actix-done-right" fork themselves. This is what we all do in the professional world when a maintainer doesn't want to upstream critical patches for whatever reason. They're under no obligation to upstream your patch, but it's open source so you're not powerless either! Why so much drama over a rejected PR?
- XelNika 7y agoCreating a fork is generally not the optimal solution. Both current and future users benefit from a patch, only those that hear about it benefit from a fork. Now, in a case like this where the maintainer won't accept patches, yes, fork and move on would have been better.