7 ms·

Sounds like the maintainer writes a lot of code using rust's "unsafe" keyword, and regularly gets issues raised about this (and versioning, and some other bits)

Sounds like the maintainer writes a lot of code using rust's "unsafe" keyword, and regularly gets issues raised about this (and versioning, and some other bits). This last issue, which included a patch, has pushed them over the edge after it descended into disagreement. Net/net they were repeatedly asked to change coding style, didn't want to, and have decided it's better to just avoid the arguments by not publishing code.

teddyuk 7y ago
The maintainer can choose whatever style they damn well please, if you don't like it don't use it. What is hard about this?
- dsego 7y ago
  Is it a community run project or not? The website seems to imply that the community is welcome to participate: "We're a welcoming community so don't be afraid to engage."
  - zzzcpan 7y ago
    There is no such thing as a community run project. But either way, people told the author to literally stop writing Rust code because he doesn't respect semver. This is not a participation, this is just hate.
  - stjohnswarts 7y ago
    There's a difference between engaging and putting up with raging users
- logophobia 7y ago
  It's not coding style, it's refusing to investigate use-after-free vulnerabilities in code because it's "boring". Noone should care if a maintainer uses tabs or spaces, or has weird variable naming, but if "coding-style" leads to security issues (due to hand-rolling unsafe memory-primitives), then it is an actual issue, especially if it's for a popular web-framework. Don't like it, don't use it doesn't really apply to security vulnerabilities in such major packages. Flaming and personal attacks are not the solution to this stuff, but this drama feels somewhat self-inflicted.
  - zzzcpan 7y ago
    > it's refusing to investigate use-after-free vulnerabilities Please investigate yourself, don't ask others to do the work you consider important for you for free.
    - Sharlin 7y ago
      The reporter included a patch.
    - jeltz 7y ago
      People did investigate for him and write a patch for him and he dismissed the patch with it being "boring".
      - zzzcpan 7y ago
        Well, maybe people didn't provide detailed enough explanation for the author to understand and merge the patch, so he didn't bother.
        jeltz 7y ago
        Judge for yourself: https://web.archive.org/web/20200116203731/https://github.com/actix/actix-net/issues/83 https://web.archive.org/web/20200116203731/https://github.co...
        ryandrake 7y ago
        It seems like the better solution here would have been for the folks who wanted a fixed version of the software to create and maintain a "actix-done-right" fork themselves. This is what we all do in the professional world when a maintainer doesn't want to upstream critical patches for whatever reason. They're under no obligation to upstream your patch, but it's open source so you're not powerless either! Why so much drama over a rejected PR?
        7y ago
- hobofan 7y ago
  Civility, apparently. Some people just never "grow up" and/or learn how to treat people with respect, and developers are not special in that regard.

teddyuk 7y ago

The maintainer can choose whatever style they damn well please, if you don't like it don't use it. What is hard about this?

dsego 7y ago
Is it a community run project or not? The website seems to imply that the community is welcome to participate: "We're a welcoming community so don't be afraid to engage."
- zzzcpan 7y ago
  There is no such thing as a community run project. But either way, people told the author to literally stop writing Rust code because he doesn't respect semver. This is not a participation, this is just hate.
- stjohnswarts 7y ago
  There's a difference between engaging and putting up with raging users
logophobia 7y ago
It's not coding style, it's refusing to investigate use-after-free vulnerabilities in code because it's "boring". Noone should care if a maintainer uses tabs or spaces, or has weird variable naming, but if "coding-style" leads to security issues (due to hand-rolling unsafe memory-primitives), then it is an actual issue, especially if it's for a popular web-framework. Don't like it, don't use it doesn't really apply to security vulnerabilities in such major packages. Flaming and personal attacks are not the solution to this stuff, but this drama feels somewhat self-inflicted.
- zzzcpan 7y ago
  > it's refusing to investigate use-after-free vulnerabilities Please investigate yourself, don't ask others to do the work you consider important for you for free.
  - Sharlin 7y ago
    The reporter included a patch.
  - jeltz 7y ago
    People did investigate for him and write a patch for him and he dismissed the patch with it being "boring".
    - zzzcpan 7y ago
      Well, maybe people didn't provide detailed enough explanation for the author to understand and merge the patch, so he didn't bother.
      - jeltz 7y ago
        Judge for yourself: https://web.archive.org/web/20200116203731/https://github.com/actix/actix-net/issues/83 https://web.archive.org/web/20200116203731/https://github.co...
        ryandrake 7y ago
        It seems like the better solution here would have been for the folks who wanted a fixed version of the software to create and maintain a "actix-done-right" fork themselves. This is what we all do in the professional world when a maintainer doesn't want to upstream critical patches for whatever reason. They're under no obligation to upstream your patch, but it's open source so you're not powerless either! Why so much drama over a rejected PR?
        7y ago
hobofan 7y ago
Civility, apparently. Some people just never "grow up" and/or learn how to treat people with respect, and developers are not special in that regard.