4 ms·
It really pisses me off when devs start ripping out asserts and tests that fail "But have been doing so for a while, so clearly they aren't needed." How about.
by Darkphibre 7y ago
It really pisses me off when devs start ripping out asserts and tests that fail "But have been doing so for a while, so clearly they aren't needed."
How about... no. Review the code and determine our undefined behavior is understood well enough that we can accept the bad inputs. Those asserts & tests were created for a reason, and need to be maintained. Not just removed because no one can spot the subtle failure modes.
- eru 7y agoYes, though fragile tests can be a sign that simplification might benefit your system. Sometimes it's useful to just turn flaky failures into solid failures.