3 ms·

It's still like that in CPython: https://github.com/python/cpython/blob/master/Lib/tempfile.py#L542 https://github.com/python/cpython/blob/master/Lib/tempfile.p

It's still like that in CPython: https://github.com/python/cpython/blob/master/Lib/tempfile.py#L542 https://github.com/python/cpython/blob/master/Lib/tempfile.p... If there's a strong enough case that this is broken (and the KeyboardInterrupt example is a good one), I think we should file a bug about it. EDIT: Created issue39318: https://bugs.python.org/issue39318 https://bugs.python.org/issue39318. I think the possibility of this failing due to a KeyboardInterrupt, even if remote, is sufficient to consider this a bug (and with KeyboardInterrupt, it would be extremely subtle and hard to reproduce - more reason to get it fixed).

avip 7y ago
Impressive debugging expertise! relevant history: https://bugs.python.org/issue21058 https://bugs.python.org/issue21058 https://bugs.python.org/issue26385 https://bugs.python.org/issue26385
- nneonneo 7y ago
  Wacky: the patch given in the initial submission of issue21058 is correct, but the patch that was actually committed incorrectly placed the wrapper inside the try block.
  - mixmastamyk 7y ago
    Interesting, that bug/patch was written by a guy I worked with at weta. He was always pushing code past its breaking point. I remember reading this bug before. Looks like his fix didn’t have this bug. It may have been modified later, his patch was from 2014.