4 ms·
> > Firstly, I didn’t talk to the person who wrote it. I rewrote the code and checked it in without their input. > Do you really need to talk to different 10
by flurdy 7y ago
> > Firstly, I didn’t talk to the person who wrote it. I rewrote the code and checked it in without their input.
> Do you really need to talk to different 10 people to maintain to make a change?
No, you don't talk to all of the 10 contributors. But if you want to still work as a team you should talk to a few. Depending on the size of the change.
Some or even all of the previous contributors may no longer be at the company or are inaccessible. But a super quick discussion with 1-3 other team members should float if this is a good idea or not.
Obviously, if you practise pair programming, most smaller rewrites just need a consensus within the pair, and a more extensive change may be a good idea to get the approval of another pair, especially if some other team members were the original contributors.
There is no need to be precious about any existing code. Nor any need to be a bull-in-china-shop either.
- 29athrowaway 7y agoFor quick changes, you can simply submit your changes in a pull request and assign them as reviewers. For non-quick changes (that are worth the cost), you can have a discussion about it and evaluate pros and cons.