5 ms·

The Comma One source code was put online (I think by the author?) and deemed to be incredibly dangerous. If I recall there was very little error handling. Does

The Comma One source code was put online (I think by the author?) and deemed to be incredibly dangerous. If I recall there was very little error handling. Does anyone know what has really changed since then?

rvz 7y ago
Well, it didn't take me long to find a message about this on the frontpage that clearly says: > Keep your eyes on the road. > "While engaged, openpilot includes camera based driver monitoring that works both day and night to alert the driver when their eyes are not on the road ahead" Also, if there are deaths around other autonomous systems like we have seen from Tesla and Uber then perhaps they're even more dangerous as they are closed-systems, unlike this then.
bugsy924 7y ago
Yeah plenty has changed since then, there are limits that are checked twice to ensure the driver is always able to take control. If violated, the car or openpilot throws an error openpilot.comma.ai
- fabiensanglard 7y ago
  Source (i assume you read the source code and know where these checks are)?
  - enragedcacti 7y ago
    https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38ce22fa25ddffbd1d3084e3/panda/board/safety.h#L156 https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38...
    - enragedcacti 7y ago
      This was harder to find but this is where caps for steering are set in OpenPilot: https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38ce22fa25ddffbd1d3084e3/selfdrive/controls/lib/latcontrol_indi.py#L99 https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38...
      - enragedcacti 7y ago
        Last but not least, here is brake and gas limiting: https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38ce22fa25ddffbd1d3084e3/selfdrive/controls/lib/longcontrol.py#L76 https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38...
agumonkey 7y ago
the tensorflow codebase ? I forgot I read that..
deleted 7y ago
[deleted]

rvz 7y ago

Well, it didn't take me long to find a message about this on the frontpage that clearly says: > Keep your eyes on the road. > "While engaged, openpilot includes camera based driver monitoring that works both day and night to alert the driver when their eyes are not on the road ahead" Also, if there are deaths around other autonomous systems like we have seen from Tesla and Uber then perhaps they're even more dangerous as they are closed-systems, unlike this then.

bugsy924 7y ago

Yeah plenty has changed since then, there are limits that are checked twice to ensure the driver is always able to take control. If violated, the car or openpilot throws an error openpilot.comma.ai

fabiensanglard 7y ago
Source (i assume you read the source code and know where these checks are)?
- enragedcacti 7y ago
  https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38ce22fa25ddffbd1d3084e3/panda/board/safety.h#L156 https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38...
  - enragedcacti 7y ago
    This was harder to find but this is where caps for steering are set in OpenPilot: https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38ce22fa25ddffbd1d3084e3/selfdrive/controls/lib/latcontrol_indi.py#L99 https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38...
    - enragedcacti 7y ago
      Last but not least, here is brake and gas limiting: https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38ce22fa25ddffbd1d3084e3/selfdrive/controls/lib/longcontrol.py#L76 https://github.com/commaai/openpilot/blob/a2ae18d1dbd1e59c38...

agumonkey 7y ago

the tensorflow codebase ? I forgot I read that..

deleted 7y ago

[deleted]