5 ms·
> It sounds like the underlying code has expectations that the HashSet exists and is valid, which in and of itself is bad code. How is that bad code? No NPE an
by hk__2 7y ago
> It sounds like the underlying code has expectations that the HashSet exists and is valid, which in and of itself is bad code.
How is that bad code? No NPE and other null-related issues, cleaner API, easier to test.
- remote_phone 7y agoThe fact that it cost $500,000 in real money because of this code is more than enough proof that it’s bad code. Plus it’s a small enough change that if it gets modified again, it will cause further money loss.
- hk__2 7y ago> The fact that it cost $500,000 in real money because of this code is more than enough proof that it’s bad code. If this is a proof of anything, it’s that it can be optimized; not that it’s bad code.