34 ms·
Out of curiosity, is there any disadvantage in making the TODO comments and then removing them before merging the result into master?
by ShinTakuya 7y ago
Out of curiosity, is there any disadvantage in making the TODO comments and then removing them before merging the result into master?
- TeMPOraL 7y agoYes. At that point in time, these comments are by definition a list of things that still needs to be done. Removing that will lead to forgetting it, and may create a false impression that the committed code is 100% complete.
- ShinTakuya 7y agoBy removing it I mean moving it into the appropriate bug/issue tracker.
- tjoff 7y agoIn my eyes, yes. I'm quite thankful if the code I'm reading is honest and tells me about stuff not up to par with whoever wrote the code/reviewed it expected. With a TODO it can often be easy to figure out if the feature/bug I'm working on is affected by it. Potentially a huge time saver.
- ShinTakuya 7y agoThat's a fair point regarding visibility. I'll have to reconsider the pluses and minuses because before now I only really saw it as a "too lazy to make a ticket" thing.