3 ms·

Very cool find! Just checked this on the GitHub mobile beta (https://github.com/mobile https://github.com/mobile), and Dash shows up in searches and from a bit

• tyingq 7y ago
  I forked the repo here: https://github.com/tyingq/test https://github.com/tyingq/test and it bombs with http 500 if I browse from desktop, but not from a mobile browser. The README.md bombs in either: https://github.com/tyingq/test/blob/master/README.md https://github.com/tyingq/test/blob/master/README.md Which is curious... Edit: Unrelated, but the 500 pages pull in this js: https://github.com/_error.js https://github.com/_error.js Which has some interesting stuff at the bottom that watches for a keypress consisting of a backtick, that then does: window.location = '/site/toggle_site_admin_and_employee_status'
  • taywrobel 7y ago
    Poking around the ruby code, it looks like it's any place that GitHub attempts to generate a link back to itself. The formatter generates the URI and then validates it against the route matcher, notices that the username constraint isn't matched and bombs out at that point. I'm not familiar enough with this code to know the potential side effects of changing that, so I'll file an issue for now, but that' the gist of it, for those curious!
    • tyingq 7y ago
      Interesting that https://github.com/-Cor- https://github.com/-Cor- works, so the username constraints vary in what's enforced.