2 ms·
Curious, would you ever approve a third party change to a lockfile? I maintain a very large OSS project and I don’t know any reason I would accept a PR that cha
by jakear 7y ago
Curious, would you ever approve a third party change to a lockfile? I maintain a very large OSS project and I don’t know any reason I would accept a PR that changes the lockfile.
- reificator 7y agoWould you accept a PR that changes the package.json file to add a new dependency?
- jakear 7y agoNot likely, we try to minimize dependancies as much as possible. If a new feature were to absolutely necessitate a new dependency, it probably wouldn't be open for third party contributions in the first place (not least of all because maintenance of the dep now falls onto us if ever upstream falters).
- tobyhinloopen 7y agoYou could just discard the PR’s lock and generate your own in the PR