5 ms·
It's not something I did per se, but one former employer had mandatory pre-checkin code review. This is a controversial practice but in my experience, only with
by neilk 16y ago
It's not something I did per se, but one former employer had mandatory pre-checkin code review. This is a controversial practice but in my experience, only with people who haven't really tried it.
Not only does this help find bugs, it will force you to write code that isn't embarrassing. You will end up communicating much more with colleagues; before, during, and after the code review process. I believe it will clean up, or at least address, almost every bad habit you have.
If you can't get this at work, try an open source project that has a similar review process.
- dalore 16y agoI've implemented this too. You take a branch of the mainline, work on your feature, integrate mainline if it has moved on in the meantime. When your ready to submit you tell one of the reviewers. They checkout your branch, do a diff and if it's good they submit. If they have questions you talk about it and if something is not right or missing, they get told to add it. It stops lazy check ins and it means at least 2 people know what code has gone in recently.