3 ms·
I like this. A large description of what's changed does a load of good. What kills me is when using pull requests, putting a complete description into the pul
by ivl 7y ago
I like this. A large description of what's changed does a load of good.
What kills me is when using pull requests, putting a complete description into the pull request... and then finding my commits not squashed after my PR is approved.
- MayeulC 7y agoWell, I usually prefer to write descriptive commit messages for individual commits before opening a pull request. If I feel it needs to be squashed, I will do it myself. It crushes my heart every time someone squashes my detailed, self-contained commits together. If there is more information in the PR than in the commit messages themselves, I will add that to the merge commit (see my other comment about merge commits).