3 ms·
As a programmer who has way more things to do than I have time for... I think this is a perfectly fair response. Good patches take me about 10 seconds to merge
by ekidd 16y ago
As a programmer who has way more things to do than I have time for...
I think this is a perfectly fair response. Good patches take me about 10 seconds to merge, and bad patches take me 20+ minutes, because I have to (1) understand what they're supposed to accomplish, (2) write unit tests, and (3) rewrite the code. In a case like that, it's usually a waste of everybody's time.
In general, when I start contributing to a new project, I begin with a bug fix, and include both unit tests and a detailed commit message. Then I plan on rewriting it at least once, because the upstream project has perfectly valid constraints that I don't understand.