4 ms·

Doesn't 'fix' already mean there was a bug, that was 'fix'-ed?

• Liquidor 7y ago
  > Doesn't 'fix' already mean there was a bug, that was 'fix'-ed? Read this: https://stackoverflow.com/questions/3580013/should-i-use-past-or-present-tense-in-git-commit-messages https://stackoverflow.com/questions/3580013/should-i-use-pas... TLDR from the Git repo: Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior. People have different opinions on what tense to use, but the one that scales better would be in imperative mood. See example here: https://github.com/facebook/react https://github.com/facebook/react
  • SifJar 7y ago
    I don't think this answers the question?
    • kickopotomus 7y ago
      Agreed. I think this actually argues in favor of using a [fix] tag over [bug].
    • Liquidor 7y ago
      How come? As I understand the comment, the user is questioning the tense of "fix" and I'm providing a reason and an example as to why someone would use imperative mood in their commit message. Edit: Nevermind. I must have been tired yesterday. User wasn't questioning the tense, but pointing out that the part of the message "fix" making the :emoji: redundant.
• fbnlsr 7y ago
  A better example would be: `:lipstick: Revamp login modal`