4 ms·
It's an unfortunate trend. I got a PR merged which removed an "Is GenuineIntel" check in the ZFS on Linux crypto layer. It checked for GenuineIntel, and only if
by Teknoman117 7y ago
It's an unfortunate trend. I got a PR merged which removed an "Is GenuineIntel" check in the ZFS on Linux crypto layer. It checked for GenuineIntel, and only if found did it check cpuid. Dunno who originally checked that in, but it seemed pretty ridiculous to me. AMD has had an AES-NI implementation since Bulldozer.
I feel it would have been acceptable to say if you had a mutant x86 CPU which set the AES-NI bit in CPUID and then had a non-compliant implementation l, that was on you.
- PedroBatista 7y agoProbably some guy trying to clean his ToDo list, but in recent times as we scratch more than the surface, there’s a real possibility that guy’s paycheck was “Genuine Intel” too.
- robin_reala 7y agoThat feels like an easy string to search for across open source projects. Are there any other low-hanging fruit in core libraries?