4 ms·

Code review is not linter. Code review is a chance to discuss design, scaling, trade-offs and mentor others. I don't think this solution will offer it.

MisterPea 7y ago
I think this does what you mention and not the former. I would imagine this works best when you have a codebase that heavily utilizes the AWS SDK so it can internally 'paint a picture' of what's going on and provide better architectural decisions and other best practices. How well it works is beyond me though
- randomidiot666 7y ago
  Bullshit. You are vastly overestimating the "intelligence" of this overpriced linter. It mechanically detects patterns. See this example: https://d1.awsstatic.com/re19/Screenshot_Catch-Code-Issue_2%20-%20Annotations%20LP.df0deb64bbfb02219d429db4d5bd3efd089e2a89.png https://d1.awsstatic.com/re19/Screenshot_Catch-Code-Issue_2%... The kind of human-level artificial intelligence that you're suggesting this would have, is science fiction.
  - MisterPea 7y ago
    Well I stand corrected, would've expected more from a company that knows all the best practices for their own services
BinaryIdiot 7y ago
> Code review is a chance to discuss design, scaling, trade-offs and mentor others. Trade offs sure but design and scaling need to be considered _before_ the code review. Maybe an architecture review of sorts? Once you hit code review it's a little too late to reconsider design and scale unless it's a serious issue. > mentor others Mentoring is mostly outside of a code review. Sure it can help with that but I don't think that really counts. IMO anyway.
- GordonS 7y ago
  > Mentoring is mostly outside of a code review Strongly disagree, at least for remote teams. Working remotely, I've personally found code reviews to be a great way of mentoring less experienced team members. I also encourage junior team members to review code of more experienced team members. For big changes, we discuss proposal/API/code reviews as a team. I've had several people provide feedback that they've learned a lot from reviews like this, and honestly I wish I'd had this kind of mentoring when I started out (I was basically a one-man cowboy-coder for the first 5 years or so of my career). I know mentoring can be seen as a chore for many, but it can be seriously rewarding too!
jhall1468 7y ago
If you're discussing design and scaling at code review, you have a serious, SERIOUS, problem. That's what design docs are for.
ur-whale 7y ago
Fair enough about the design discussions, but I also think this is quite a little bit more than a linter.

MisterPea 7y ago

I think this does what you mention and not the former. I would imagine this works best when you have a codebase that heavily utilizes the AWS SDK so it can internally 'paint a picture' of what's going on and provide better architectural decisions and other best practices. How well it works is beyond me though

randomidiot666 7y ago
Bullshit. You are vastly overestimating the "intelligence" of this overpriced linter. It mechanically detects patterns. See this example: https://d1.awsstatic.com/re19/Screenshot_Catch-Code-Issue_2%20-%20Annotations%20LP.df0deb64bbfb02219d429db4d5bd3efd089e2a89.png https://d1.awsstatic.com/re19/Screenshot_Catch-Code-Issue_2%... The kind of human-level artificial intelligence that you're suggesting this would have, is science fiction.
- MisterPea 7y ago
  Well I stand corrected, would've expected more from a company that knows all the best practices for their own services

BinaryIdiot 7y ago

> Code review is a chance to discuss design, scaling, trade-offs and mentor others. Trade offs sure but design and scaling need to be considered _before_ the code review. Maybe an architecture review of sorts? Once you hit code review it's a little too late to reconsider design and scale unless it's a serious issue. > mentor others Mentoring is mostly outside of a code review. Sure it can help with that but I don't think that really counts. IMO anyway.

GordonS 7y ago
> Mentoring is mostly outside of a code review Strongly disagree, at least for remote teams. Working remotely, I've personally found code reviews to be a great way of mentoring less experienced team members. I also encourage junior team members to review code of more experienced team members. For big changes, we discuss proposal/API/code reviews as a team. I've had several people provide feedback that they've learned a lot from reviews like this, and honestly I wish I'd had this kind of mentoring when I started out (I was basically a one-man cowboy-coder for the first 5 years or so of my career). I know mentoring can be seen as a chore for many, but it can be seriously rewarding too!

jhall1468 7y ago

If you're discussing design and scaling at code review, you have a serious, SERIOUS, problem. That's what design docs are for.

ur-whale 7y ago

Fair enough about the design discussions, but I also think this is quite a little bit more than a linter.